Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(apple): Add docs for swizzleClassNameExcludes #10992

Merged
merged 4 commits into from
Aug 14, 2024
Merged

feat(apple): Add docs for swizzleClassNameExcludes #10992

merged 4 commits into from
Aug 14, 2024

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Aug 6, 2024 •
edited
Loading

DESCRIBE YOUR PR

Add docs for the existing option swizzleClassNameExcludes.

IS YOUR CHANGE URGENT?

Help us prioritize incoming PRs by letting us know when the change needs to go live.

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

SLA

  • Teamwork makes the dream work, so please add a reviewer to your PRs.
  • Please give the docs team up to 1 week to review your PR unless you've added an urgent due date to it.
    Thanks in advance for your help!

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

@philipphofmann
feat(apple): Add docs for swizzleClassNameExcludes
11a095f 
Add docs for the existing option swizzleClassNameExcludes.
@philipphofmann
feat(apple): Add docs for swizzleClassNameExcludes
e5668b3 
Add docs for the existing option swizzleClassNameExcludes.
@philipphofmann philipphofmann requested a review from a team August 6, 2024 12:51
@vercel Vercel
Copy link

vercel bot commented Aug 6, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
changelog ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 6:53am
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 7, 2024 6:53am
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
develop-docs ⬜️ Ignored (Inspect) Visit Preview Aug 7, 2024 6:53am

@codecov Codecov
Copy link

codecov bot commented Aug 6, 2024 •
edited
Loading

Bundle Report

Changes will decrease total bundle size by 15 bytes ⬇️

Bundle name Size Change
sentry-docs-server 8.25MB 6 bytes ⬇️
sentry-docs-edge-server 252.6kB 3 bytes ⬇️
sentry-docs-client 6.24MB 6 bytes ⬇️

brustolin
brustolin approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Maybe I would add somewhere as a tip that the best way to avoid mistakes is to use: NSStringFromClass function.

kahest
kahest approved these changes Aug 6, 2024
View reviewed changes
Copy link
Member

@kahest kahest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this 🙏 left small wording suggestions for clarity

docs/platforms/apple/common/tracing/instrumentation/automatic-instrumentation.mdx Outdated Show resolved Hide resolved
docs/platforms/apple/common/configuration/swizzling.mdx Outdated Show resolved Hide resolved
@philipphofmann philipphofmann merged commit 469b818 into master Aug 14, 2024
9 checks passed
@philipphofmann philipphofmann deleted the feat/apple-skip-swizzling-classes branch August 14, 2024 05:49
@github-actions github-actions bot locked and limited conversation to collaborators Aug 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brustolin brustolin brustolin approved these changes

@kahest kahest kahest approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@philipphofmann @kahest @brustolin